Refactor FXIOS-7301 - Remove 2 closure_body_length violations from MainMenuMiddleware.swift (Firefox) and InternalTelemetrySettingsView.swift (Focus)

[ionixjunior]

📜 Tickets

Jira ticket
Github issue

💡 Description

This PR removes 2 closure_body_length violations from the MainMenuMiddleware.swift (Firefox) and InternalTelemetrySettingsView.swift (Focus). Also, it decreases the threshold to 42.

The most controversial change in this PR is in the MainMenuMiddleware.swift file. In this file, I changed the mainMenuProvider property, splitting it into separated functions. I created three new functions, each one based on the ActionType: MainMenuActionType, GeneralBrowserActionType, and MainMenuDetailsActionType. To the last one, I needed to add the @unknown keyword, because all option already available into switch case statement.

Please, feel free to give me suggestions about how can we improve this.

This PR is part of a series of PRs described here #16442 (comment) and here #16442 (comment).

📝 Checklist

You have to check all boxes before merging

• Filled in the above information (tickets numbers and description of your work)
• Updated the PR name to follow our PR naming guidelines
• Wrote unit tests and/or ensured the tests suite is passing
• When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• If needed, I updated documentation / comments for complex code and public methods
• If needed, added a backport comment (example @Mergifyio backport release/v120)

[FilippoZazzeroni]

Just a nit refactor for MainMenuMiddleware the rest looks good to me

[FilippoZazzeroni]

Could we change this to instead of checking if the method handles the action, to check for the action type, like we did in other cases.

if let action = action as? GeneralBrowserAction {
 handleGeneralBrowserAction()
}

With this we can avoid also returning a boolean to check if the action was handled. What do you think @ionixjunior let me know if it makes sense what i said, thanks 😃