Add FXIOS-12039 [Homepage] section viewed telemetry (backport #26234) #26281
+136
−129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Replace
item_viewed
telemetry event (previous PR) withsection_viewed
labeled_counter.Added a throttler to delay because when we
scrollToTop
it was still tracking impressions for the sections on the bottom when from the user perspectives they don't see those sections.Separate logic for top sites items and sections.
Cases should be tested
For both new homepage + old homepage, impressions are triggered:
Load webpage -> tap on home button -> view homepage
Load webpage -> Add new tab from tab tray -> view homepage
Load webpage -> long pressing on tab tray to open new tab -> view homepage
Load webpage -> Add new tab from menu -> view homepage
Select homepage -> View webpage -> navigate back to homepage
Load webpage -> select on URL -> view homepage
On Homepage -> Add new tab from tab tray -> view homepage
On Homepage -> Add new tab from menu-> view homepage
Oh Homepage -> long pressing on tab tray to open new tab -> view homepage
Note: If on homepage, show modal (i.e. settings, menu), no impression is triggered
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)Video Capture
Telemetry_demo.mov
This is an automatic backport of pull request #26234 done by [Mergify](https://mergify.com).