fix: preserve redis notification metadata#1154
Open
napiany wants to merge 1 commit into
Open
Conversation
Keep ttl, topic, and sortkey_timestamp in Redis-stored notifications so message IDs remain stable after JSON round-trips. Previously Redis zset members were created from the full notification metadata, but the stored JSON omitted that metadata. On reconnect, deserialized notifications fell back to legacy message IDs and cleanup deleted the wrong Redis entries, causing repeated backlog replay.
Member
|
Have you (or anyone else) ran the redis backend against the integration test suite (and are they currently runnable against it)? I'm wondering if they caught/would have caught such a bug, or should a new test showing this issue be added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve
ttl,topic, andsortkey_timestampwhen serializing Redis-backedStorableNotificationrecords.The Redis save path creates zset members using
Notification::chidmessageid(), which depends ontopicorsortkey_timestamp. The current stored JSON omits those fields, so after deserialization the notification falls back to the legacychannel_id:versionmessage ID. That makes reconnect/backlog cleanup delete the wrong Redis member/key and can cause repeated replay of stored notifications.This patch keeps the metadata in the stored JSON.