[AIMOD-1354] Add "delete" index for AMP keywords#19
Open
vazish wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SymIndex.build()function that builds the delete index over the full keywords, i.e. generates for the keyword example"world cup" -> "orld cup", "wrld cup", "word cup, ...query_fuzzy()for the how it's called.Some stats / tests done for latency, RSS:
AMP fuzzy index — perf & memory (before/after)
Measured on real US-desktop MARS (3,959 suggestions). Before = v0.3.1 (no fuzzy), after = v0.3.2 (with fuzzy).
Build time (per index — runs once per MARS cron resync)
Query latency (µs)
Exact path is unchanged before/after; fuzzy is a new fallback, only on an exact miss.
RSS footprint (per built index)
Memory-leak check (0.3.2)
Summary: ~+10 ms build and ~+8 MB per segment index; zero impact on the exact hot path;back; no leaks.