test: fix flake in test_users_with_the_same_batch_id_get_separate_data #1981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to _switch_user picking up old test data Closes STOR-415
pjenvey
force-pushed
the
test/same_batch_id-flake-STOR-415
branch
from
64c552d to
07f2b9e
Compare
taddes
approved these changes
Jan 7, 2026
Collaborator
taddes
left a comment
taddes
left a comment
There was a problem hiding this comment.
We'll just get a good idea of how long it takes now with this change. I have to refresh my memory a bit with some of pytest's fixture setup/teardown configs as I know there are ways to make those processes more efficient between test runs.
Member
Author
|
Still only took about 90 seconds in this PR's run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to _switch_user picking up old test data
Testing
This might slow down
test_users_with_the_same_batch_id_get_separate_data(which is already slow, according to circleci Test Insights, taking up to 90 seconds at least on uuid based batch id spanner/postgres backends).I might log a separate issue to disable this test entirely on those backends, especially if this change adds a significant slowdown, since they shouldn't be generating same batch ids anyway
Issue(s)
Closes STOR-415