fix(auth): scope info/collections expiry exemption to its exact route#2435
Merged
Conversation
The Hawk expiry exemption for the legacy read-only /1.5/{uid}/info/collections endpoint was applied to any path ending in "/info/collections", which also matches the storage route /1.5/{uid}/storage/info/collections (collection "info", item "collections"). Match the legacy route exactly (four path segments) so the exemption no longer applies to that writable storage item. Adds a unit test.
Closes STOR-620
The clippy, clippy-release, and rust-checks jobs only restored the Rust toolchain cache and ran `rustup default`, which yields a toolchain without the clippy/rustfmt components when the `*-rust-toolchain-${RUST_VERSION}` cache is absent (e.g. after a RUST_VERSION bump) or holds a component-less toolchain, causing "cargo-clippy is not installed" failures. These jobs now install the components idempotently. Likewise, python-checks now runs `poetry install` so ruff/mypy/etc. are present when the virtualenv cache misses.
pjenvey
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hawk expiry exemption for the legacy read-only
/1.5/{uid}/info/collectionsendpoint was keyed off a/info/collectionspath suffix, which also matches the storage route/1.5/{uid}/storage/info/collections(collectioninfo, itemcollections). This matches the legacy route exactly (four path segments) so the exemption applies only there. Adds a unit test.This branch also includes the CI workflow fix (install
clippy/rustfmtcomponents and runpoetry installon cache miss) so it passes CI — it is the identical commit already on the other open fix branches and will collapse to a no-op once any of them merges tomaster.Testing
Closes STOR-620