Skip to content

Conversation

@legobeat
Copy link
Contributor

Was originally moved to runtime dependencies in 7fd4680.

Seems safe and idiomatic to move it back with the other typings packages.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.50%. Comparing base (6821e69) to head (f81bd49).
⚠️ Report is 143 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files          11       11           
  Lines         440      440           
  Branches       97       97           
=======================================
  Hits          429      429           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legobeat legobeat marked this pull request as ready for review May 18, 2023 07:50
@willdurand
Copy link
Member

I suppose there was a reason to move these two to dependencies but I don't remember.

@legobeat
Copy link
Contributor Author

I suppose there was a reason to move these two to dependencies but I don't remember.

Test are passing and from a quick look nothing stood out to me as exceptional here - if it was something tooling-related at the time, I'd guess it's been resolved since?

Was originally moved to runtime dependencies in
7fd4680.

Seems safe and idiomatic to move it back with the other typings
packages.
@legobeat legobeat force-pushed the deps-types-to-devdeps branch from 0689fe2 to f81bd49 Compare April 22, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants