DO NOT MERGE - add logins store static key manager factory #6696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for developing as logins for desktop, milestone 3. It is not intended to be merged.
1. Look at Cargo.toml, find revision for application-services, eg
then rev is
8e84c588a5cc2686973c5026ecd240d6275d7e94
. This branch is branched from this rev, so no need for step 2 if above rev matches.2. Rebase jo:as-logins-on-desktop-milestone-3 (#6696) to that revision
3. replace the revision with above branch, and add logins
4. Define dependencies for uniffi
(note 1: I haven't tested the need of declaring hawk and base16 deps with current code)
(note 2: we do not use the feature keydb because 8e84c58 did not include it yet)
5. Ensure no commits
except the Cargo dep changes
6. Vendor Rust
7. Configure UniFFI exports
and ensure they're sync:
(note: to betested whether this needed at all, looks like its sync per default)
8. Generate JavaScript Bindings
Sadly, this currentltly fails due to https://bugzilla.mozilla.org/show_bug.cgi?id=1959469
Mark knows more.