Skip to content

Bug 1967617 - Replace individual Geoname::admin{level}_code properties with one admin_division_codes map #6758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: adw/geonames-l10n-bug-1958992
Choose a base branch
from
+85 −134
Open

Bug 1967617 - Replace individual Geoname::admin{level}_code properties with one admin_division_codes map #6758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f665e8
Bug 1967617 - Replace individual `Geoname::admin{level}_code` propert…
0c0w3 May 20, 2025
02e9517
Use `copied` instead of `cloned`
0c0w3 May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions components/suggest/src/benchmarks/geoname.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,12 @@ impl BenchmarkWithInput for GeonameBenchmark {
pub fn all_benchmarks() -> Vec<(&'static str, GeonameBenchmark)> {
let ny_state = Geoname {
geoname_id: 5128638,
geoname_type: GeonameType::Admin1,
geoname_type: GeonameType::AdminDivision { level: 1 },
name: "New York".to_string(),
feature_class: "A".to_string(),
feature_code: "ADM1".to_string(),
country_code: "US".to_string(),
admin1_code: Some("NY".to_string()),
admin2_code: None,
admin3_code: None,
admin4_code: None,
admin_division_codes: [(1, "NY".to_string())].into(),
population: 19274244,
latitude: "43.00035".to_string(),
longitude: "-75.4999".to_string(),
Expand Down
Loading