Add FXIOS-15014 [RS] Expose reset _storage method to consumers#7253
Open
issammani wants to merge 2 commits intomozilla:mainfrom
Open
Add FXIOS-15014 [RS] Expose reset _storage method to consumers#7253issammani wants to merge 2 commits intomozilla:mainfrom
reset _storage method to consumers#7253issammani wants to merge 2 commits intomozilla:mainfrom
Conversation
Contributor
Author
issammani
force-pushed
the
feat/expose-rs-reset-storage
branch
from
9dd4a68 to
8e439d3
Compare
bendk
approved these changes
Mar 4, 2026
Contributor
bendk
left a comment
bendk
left a comment
There was a problem hiding this comment.
Looks good to me, I just found some minor issues. Feel free to deal with them however you want, I don't need to re-review.
| } | ||
| } | ||
|
|
||
| #[cfg(not(feature = "signatures"))] |
Contributor
There was a problem hiding this comment.
Is this needed? I'd expect the test to work regardless of that feature.
|
|
||
| rs_client.reset_storage().expect("Failed to reset storage"); | ||
|
|
||
| // After reset, both records and attachments should be gone |
Contributor
There was a problem hiding this comment.
This could also test that records/attachments with packaged data are reverted to the packaged versions. I don't think that's totally necessary though, the addition of this test is already great. If you don't want test the packaged data, how about writing a comment mentioning that there could be a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
This PR:
reset_storagefor remote settings clients.Pull Request checklist
[ci full]to the PR title.