AC-93 - Allow embedders to configure context ID rotation period#7262
Open
Almaju wants to merge 1 commit intomozilla:mainfrom
Open
AC-93 - Allow embedders to configure context ID rotation period#7262Almaju wants to merge 1 commit intomozilla:mainfrom
Almaju wants to merge 1 commit intomozilla:mainfrom
Conversation
…ia AdsClient builder Add a `rotation_days` parameter to `MozAdsClientBuilder` so the embedder (e.g. HNT) can control the context ID rotation period at construction time rather than relying on the hardcoded default of 3 days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
rotation_daysparameter toMozAdsClientBuilderso the embedder (e.g. HNT) can control the context ID rotation period at construction time rather than relying on the hardcoded default of 3 days.Pull Request checklist
[ci full]to the PR title.