Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bedrock Glean implementation #15888

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Remove bedrock Glean implementation #15888

merged 1 commit into from
Jan 17, 2025
+10 −1,164

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Jan 17, 2025 •
edited
Loading

One-line summary

Removes bedrock specific Glean implementation

Significant changes and points to review

Make sure I didn't miss any stray files or references?

Issue / Bugzilla link

N/A

Testing

  • npm start runs as expected
  • No glean.js pings visible in the console on page load

@alexgibson alexgibson added the WMO and FXC Code relevant to both the WMO and FXC projects label Jan 17, 2025
@alexgibson alexgibson requested review from a team as code owners January 17, 2025 16:34
@alexgibson alexgibson requested a review from stevejalim January 17, 2025 16:35
stevejalim
stevejalim approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree with keeping the Dockerfile changes very light for now

@stevejalim
Copy link
Collaborator

Is this for wmo AND fxc or just fxc?

@alexgibson
Copy link
Member Author

Is this for wmo AND fxc or just fxc?

Just FXC - maybe we need a different label for stuff that's merging into the springfield branch?

@alexgibson alexgibson merged commit 94f10c7 into springfield Jan 17, 2025
4 checks passed
@alexgibson alexgibson deleted the remove-glean branch January 17, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevejalim stevejalim stevejalim approved these changes

Assignees
No one assigned
Labels
WMO and FXC Code relevant to both the WMO and FXC projects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexgibson @stevejalim