Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this changeset needs to go into the FXC codebase, please add the
WMO and FXC
label. 🤷 (most likely 🔥🦊)One-line summary
Adds a little specificity to menu anchor colors, to hide flash of Fx–themed palette on some pages.
Significant changes and points to review
There seems to be some sort of JS delay involved, that applies the final color based on the state of the panel etc. as the final color is often green, not black, and if the link is blue pre-JS, the flash of unexpected color is a bit jarring. This makes the hover anchors on Fx-themed pages consistent with rest of the site.
NB: Went for
:is()
shenanigans only because SASS doesn't allowa&
(and the selector above is not for anchor but just the pseudo on the class before) and I wanted to keep the rules together with the others, not repeating another block afterwards just for this; technically it's not needed and justa:hover
would suffice otherwise to resolve this.(Oh and I'm not adding it to the rule above, as I'm working on underline-based hovers instead of boutique borders in #15855, and the decoration would interfere with that at some point…)
Issue / Bugzilla link
Fixes #15873
(also closes #16027 as superseded)
Testing
http://localhost:8000/fr/firefox/challenge-the-default/
http://localhost:8000/en/firefox/family/