-
Notifications
You must be signed in to change notification settings - Fork 952
fix firefox/all screen reader flow #15082 #16172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ | |
| <div class="c-product-info" {% if product %} data-current="{{ product.slug }}"{% endif %}> | ||
| <div class="c-intro"> | ||
| <h1 class="c-intro-heading">{{ ftl('firefox-all-choose-which-firefox') }}</h1> | ||
| <p>{{ ftl('firefox-all-everyone-deserves-access-v2', fallback="'firefox-all-everyone-deserves-access") }}</p> | ||
| <p>{{ ftl('firefox-all-everyone-deserves-access-v2') }}</p> | ||
| {% if product %} | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one too?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I removed the fallback as it doesn't exist in the current version of main. It must be from an older version of main that Rob branched from. |
||
| {% if product.slug == "desktop-release" %} | ||
| <div> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may have been removed unintentionally(?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up setting the string directly in main.html. Would it be best to define
page_descinbase.html?I'm not overly familiar with jinja, but it looks like I could use set for this.