WT-334 - Build CMS Components For Advertising Pages - Part 1 #16813
+1,439
−310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dark-section css files
…ol, and m24 sizing.
…o mozorg/advertising/landing.html
…zilla/bedrock into WT-334-cms-components-for-advertising
kkellydesign
approved these changes
Nov 20, 2025
stevejalim
approved these changes
Nov 24, 2025
Contributor
stevejalim
left a comment
stevejalim
left a comment
There was a problem hiding this comment.
Light review. r+wc
Biggest concern is the /contact/ view which I think should be removed - see comments
bedrock/mozorg/blocks/advertising.py
Outdated
| ("linkedin", "LinkedIn"), | ||
| ("tiktok", "TikTok"), | ||
| ("spotify", "Spotify"), | ||
| ("twitter", "Twitter"), |
Contributor
There was a problem hiding this comment.
I thought we weren't using Twitter for comms anymore - eg it's no longer in the Mozilla.org footer.
But if we are supporting linkss to it, it should be phrased as X not Twitter
bedrock/mozorg/templates/mozorg/cms/snippets/contact_bannet_snippet.html
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.This pull request includes the work from on #16810, which should be reviewed first
One-line summary
This pull request makes the advertising index/landing page editable through Wagtail.
Significant changes and points to review
This pull request turns the advertising page into a Wagtail-managed
AdvertisingIndexPagepage with the following components, defined inbedrock/mozorg/blocks/advertising.py:advertising_hero_blocksection_header_blockfigure_with_statistic_blockfeature_list_blockAlso, a new snippet (
ContactBannerSnippet) is available, and added to theAdvertisingIndexPage.Issue / Bugzilla link
WT-334
Testing
To test locally, go to Wagtail and create an "Advertising index page" page in the page tree. Try to make the content identical to http://localhost:8000/en-US/advertising/.