Skip to content

Conversation

@janriokrause
Copy link

Redirect french PDF pages to firefox.com

Testing:

$ curl --silent --head "http://localhost:8000/fr/firefox/features/free-pdf-editor/" | grep -E "HTTP|location"
HTTP/1.1 301 Moved Permanently
location: https://www.firefox.com/fr/features/free-pdf-editor/?redirect_source=mozilla-org

$ curl --silent --head "http://localhost:8000/fr/firefox/features/complete-pdf/" | grep -E "HTTP|location"
HTTP/1.1 301 Moved Permanently
location: https://www.firefox.com/fr/features/complete-pdf/?redirect_source=mozilla-org

Copy link
Contributor

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+

Thanks for the contribution @janriokrause - it will be in production with the next release, either today or tomorrow

@stevejalim
Copy link
Contributor

@janriokrause Actually, before I merge this, would you mind adding a couple of tests? The easiest way is to expand the current coverage by adding some new test params - here's an example of a different page being tested https://github.com/mozilla/bedrock/blob/main/bedrock/firefox/tests/test_redirects.py#L290-L295 and you can run file with pytest -k test_redirects.py

@janriokrause
Copy link
Author

Sure, thanks for the hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants