Skip to content

Conversation

@kwindau
Copy link
Contributor

@kwindau kwindau commented Dec 12, 2025

Description

  • This PR adds a schema.yaml & a "bronze" label to the view: moz-fx-data-shared-prod.telemetry.ga4_sessions_firefoxcom_mozillaorg_combined
  • It also cleans up some YAML formatting issues in bqetl_project.yaml & in a few metadata.yaml files.

Reviewer, please follow this checklist

@kwindau kwindau changed the title Column metadata chore(metadata-completeness): Add schema.yaml to ga4_sessions_firefoxcom_mozillaorg_combined Dec 12, 2025
@dataops-ci-bot

This comment has been minimized.

@dataops-ci-bot

This comment has been minimized.

@dataops-ci-bot
Copy link

Integration report for "Merge branch 'main' into column-metadata"

sql.diff

Click to expand!
Only in /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/ga4_sessions_firefoxcom_mozillaorg_combined: schema.yaml
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/fx_accounts_active_daily_clients/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/fx_accounts_active_daily_clients/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/fx_accounts_active_daily_clients/metadata.yaml	2025-12-15 17:36:21.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/fx_accounts_active_daily_clients/metadata.yaml	2025-12-15 17:36:52.000000000 +0000
@@ -1,8 +1,6 @@
 friendly_name: Firefox Accounts Active Daily Clients
 description: |-
-  Table with 1 row per submission date and Glean client ID sending a Firefox Accounts ping that date
-  Intentionally does not contain Firefox Account ID
-  Primary key is submission date & Glean client_info.client_id
+  Table with 1 row per submission date and Glean client ID sending a Firefox Accounts ping that date Intentionally does not contain Firefox Account ID Primary key is submission date & Glean client_info.client_id
 owners:
 - [email protected]
 labels:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/fx_accounts_linked_clients_ordered/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/fx_accounts_linked_clients_ordered/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/fx_accounts_linked_clients_ordered/metadata.yaml	2025-12-15 17:36:21.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/fx_accounts_linked_clients_ordered/metadata.yaml	2025-12-15 17:36:52.000000000 +0000
@@ -1,8 +1,6 @@
 friendly_name: Firefox Accounts Linked Clients Ordered
 description: |-
-  Table overwrites daily with latest information, orders clients by first seen date
-  Client ID with the smaller first seen date is client ID
-  Client ID with the larger first seen date is linked client ID
+  Table overwrites daily with latest information, orders clients by first seen date Client ID with the smaller first seen date is client ID Client ID with the larger first seen date is linked client ID
 owners:
 - [email protected]
 labels:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/ga4_sessions_firefoxcom_mozillaorg_combined/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/ga4_sessions_firefoxcom_mozillaorg_combined/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/ga4_sessions_firefoxcom_mozillaorg_combined/metadata.yaml	2025-12-15 17:36:21.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/ga4_sessions_firefoxcom_mozillaorg_combined/metadata.yaml	2025-12-15 17:36:51.000000000 +0000
@@ -1,8 +1,10 @@
-friendly_name: Ga4 Sessions Firefoxcom Mozillaorg Combined
+friendly_name: GA4 Sessions Combined - Firefox.com & Mozilla.org
 description: |-
-  Please provide a description for the query
-owners: []
-labels: {}
+  Contains 1 row per session. Primary key is a 3 part key, ga_session_id + ga_client_id + flag. The flag value indicates the website the session is from, i.e. mozilla.org or firefox.com
+owners:
+- [email protected]
+labels:
+  owner1: kwindau
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
@@ -13,4 +15,4 @@
   - moz-fx-data-shared-prod.firefoxdotcom.ga_sessions
   - moz-fx-data-shared-prod.mozilla_org.ga_sessions
 require_column_descriptions: false
-level: null
+level: bronze
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/ga4_sessions_firefoxcom_mozillaorg_combined/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/ga4_sessions_firefoxcom_mozillaorg_combined/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/ga4_sessions_firefoxcom_mozillaorg_combined/schema.yaml	1970-01-01 00:00:00.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/ga4_sessions_firefoxcom_mozillaorg_combined/schema.yaml	2025-12-15 17:29:43.000000000 +0000
@@ -0,0 +1,199 @@
+fields:
+- name: flag
+  type: STRING
+  mode: NULLABLE
+  description: Indicates which website the session is from, e.g. FIREFOX.COM or MOZILLA.ORG
+- name: ga_client_id
+  type: STRING
+  mode: NULLABLE
+  description: Google Analytics Client Identifier, using a cookie on mozilla.org.
+- name: ga_session_id
+  type: STRING
+  mode: NULLABLE
+  description: Google Analytics Session Identifier
+- name: session_date
+  type: DATE
+  mode: NULLABLE
+  description: The date the Google Analytics session started.
+- name: session_start_timestamp
+  type: DATETIME
+  mode: NULLABLE
+  description: The timestamp of the session_start event.  If no session_start event, the minimum event timestamp for that session.
+- name: is_first_session
+  type: BOOLEAN
+  mode: NULLABLE
+  description: Whether this is the first session for the client.
+- name: session_number
+  type: INTEGER
+  mode: NULLABLE
+  description: The session number for this client.  Starts at 1, consecutively increasing.
+- name: time_on_site
+  type: INTEGER
+  mode: NULLABLE
+  description: Time in seconds between the first and last event of the session.
+- name: pageviews
+  type: INTEGER
+  mode: NULLABLE
+  description: Total page views for the session.
+- name: country
+  type: STRING
+  mode: NULLABLE
+- name: region
+  type: STRING
+  mode: NULLABLE
+- name: city
+  type: STRING
+  mode: NULLABLE
+- name: device_category
+  type: STRING
+  mode: NULLABLE
+- name: mobile_device_model
+  type: STRING
+  mode: NULLABLE
+- name: mobile_device_string
+  type: STRING
+  mode: NULLABLE
+- name: os
+  type: STRING
+  mode: NULLABLE
+- name: os_version
+  type: STRING
+  mode: NULLABLE
+- name: language
+  type: STRING
+  mode: NULLABLE
+- name: browser
+  type: STRING
+  mode: NULLABLE
+- name: browser_version
+  type: STRING
+  mode: NULLABLE
+- name: first_campaign_from_event_params
+  type: STRING
+  mode: NULLABLE
+- name: distinct_campaigns_from_event_params
+  type: STRING
+  mode: REPEATED
+- name: first_source_from_event_params
+  type: STRING
+  mode: NULLABLE
+- name: distinct_sources_from_event_params
+  type: STRING
+  mode: REPEATED
+- name: first_medium_from_event_params
+  type: STRING
+  mode: NULLABLE
+- name: distinct_mediums_from_event_params
+  type: STRING
+  mode: REPEATED
+- name: first_content_from_event_params
+  type: STRING
+  mode: NULLABLE
+- name: distinct_contents_from_event_params
+  type: STRING
+  mode: REPEATED
+- name: first_term_from_event_params
+  type: STRING
+  mode: NULLABLE
+- name: distinct_terms_from_event_params
+  type: STRING
+  mode: REPEATED
+- name: first_experiment_id_from_event_params
+  type: STRING
+  mode: NULLABLE
+- name: distinct_experiment_ids_from_event_params
+  type: STRING
+  mode: REPEATED
+- name: first_experiment_branch_from_event_params
+  type: STRING
+  mode: NULLABLE
+- name: distinct_experiment_branches_from_event_params
+  type: STRING
+  mode: REPEATED
+- name: first_gad_campaignid_from_event_params
+  type: STRING
+  mode: NULLABLE
+- name: distinct_gad_campaignid_from_event_params
+  type: STRING
+  mode: REPEATED
+- name: manual_campaign_id
+  type: STRING
+  mode: NULLABLE
+- name: manual_campaign_name
+  type: STRING
+  mode: NULLABLE
+- name: manual_source
+  type: STRING
+  mode: NULLABLE
+- name: manual_medium
+  type: STRING
+  mode: NULLABLE
+- name: manual_term
+  type: STRING
+  mode: NULLABLE
+- name: manual_content
+  type: STRING
+  mode: NULLABLE
+- name: gclid
+  type: STRING
+  mode: NULLABLE
+- name: gclid_array
+  type: STRING
+  mode: REPEATED
+- name: had_download_event
+  type: BOOLEAN
+  mode: NULLABLE
+- name: firefox_desktop_downloads
+  type: INTEGER
+  mode: NULLABLE
+- name: last_reported_install_target
+  type: STRING
+  mode: NULLABLE
+- name: all_reported_install_targets
+  type: STRING
+  mode: REPEATED
+- name: last_reported_stub_session_id
+  type: STRING
+  mode: NULLABLE
+- name: all_reported_stub_session_ids
+  type: STRING
+  mode: REPEATED
+- name: landing_screen
+  type: STRING
+  mode: NULLABLE
+- name: ad_google_campaign
+  type: STRING
+  mode: NULLABLE
+- name: ad_google_campaign_id
+  type: STRING
+  mode: NULLABLE
+- name: ad_Group
+  type: STRING
+  mode: NULLABLE
+- name: ad_Group_id
+  type: STRING
+  mode: NULLABLE
+- name: ad_google_account
+  type: STRING
+  mode: NULLABLE
+- name: ad_crosschannel_source
+  type: STRING
+  mode: NULLABLE
+- name: ad_crosschannel_medium
+  type: STRING
+  mode: NULLABLE
+- name: ad_crosschannel_campaign
+  type: STRING
+  mode: NULLABLE
+- name: ad_crosschannel_campaign_id
+  type: STRING
+  mode: NULLABLE
+- name: ad_crosschannel_source_platform
+  type: STRING
+  mode: NULLABLE
+- name: ad_crosschannel_primary_channel_group
+  type: STRING
+  mode: NULLABLE
+- name: ad_crosschannel_default_channel_group
+  type: STRING
+  mode: NULLABLE

Link to full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants