Skip to content

Conversation

@Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Nov 13, 2025

References:

Jira: MNTOR-5107
Figma:

Description

This test case would result in an invalid state previously:

it should show a call to the manual resolution flow for free users with
existing scans, when the FreeOnly flag is enabled

It's a followup to #6263 (comment).

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, I've checked that it still works with the flag both on, and with the flag off.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@Vinnl Vinnl requested a review from kschelonka November 13, 2025 13:15
@Vinnl Vinnl self-assigned this Nov 13, 2025
@Vinnl Vinnl added the Review: XS Code review time: up to 30min label Nov 13, 2025
This test case would result in an invalid state previously:
> it should show a call to the manual resolution flow for free users with
> existing scans, when the `FreeOnly` flag is enabled
@@ -0,0 +1,213 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why there's a new test file for this, since the other dashboard top banner test variations were in Dashboard.test.tsx?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignorance... I wasn't aware of those (though I was surprised there were no tests). Moved and adjusted in 2cc65b0.

Copy link
Collaborator

@kschelonka kschelonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes lgtm, please reply to @codemist question before merging

@Vinnl Vinnl requested a review from codemist November 24, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review: XS Code review time: up to 30min

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants