fix(breachAlerts): update cron job to autoscaling service #6287
+1,652
−1,193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the fixed message processing count and batch pulls. Do not accept new messages after termination signals Refactor job with DI for easier unit testing
The imports and mocks in tests seem to have masked missing coverage, and moving to DI pattern revealed gaps once they were no longer imported
kschelonka
commented
Nov 20, 2025
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| import { logger } from "@sentry/utils"; | ||
| import { logger } from "@sentry/core"; |
Collaborator
Author
There was a problem hiding this comment.
this was deprecated, recommended to use @sentry/core
kschelonka
commented
Nov 20, 2025
| export const redisClient = () => { | ||
| if (process.env.REDIS_URL?.includes("redis.mock")) { | ||
| singleton = createRedisMockInstance(); | ||
| singleton = new MockRedis(); |
Collaborator
Author
There was a problem hiding this comment.
this was a one-liner in utils-mock file, which I moved here for clarity and to eliminate needing another test for that file
kschelonka
changed the title
kschelonka
changed the title
kschelonka
changed the title
kschelonka
commented
Nov 20, 2025
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| import { createRedisInstance } from "./util"; |
Collaborator
Author
There was a problem hiding this comment.
added due to coverage complaint (probably from removing this import in the test files?)
kschelonka
commented
Nov 20, 2025
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| import { isUsingMockHIBPEndpoint, isUsingMockONEREPEndpoint } from "./mock"; |
Collaborator
Author
There was a problem hiding this comment.
added due to coverage complaint (no changes to the files)
kschelonka
commented
Nov 20, 2025
|
|
||
| import { parseMarkup } from "./parseMarkup"; | ||
|
|
||
| describe("parseMarkup", () => { |
Collaborator
Author
There was a problem hiding this comment.
added due to coverage complaint (no changes to method)
kschelonka
commented
Nov 20, 2025
|
|
||
| export function isUsingMockHIBPEndpoint() { | ||
| return process.env.HIBP_KANON_API_ROOT?.includes("api/mock") as boolean; | ||
| return !!process.env.HIBP_KANON_API_ROOT?.includes("api/mock"); |
Collaborator
Author
There was a problem hiding this comment.
this was returning undefined if HIBP_KANON_API_ROOT was unset; !! is idiomatic boolean conversion
kschelonka
requested review from
Vinnl,
codemist and
mansaj
and removed request for
mansaj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira:
Required for: https://mozilla-hub.atlassian.net/browse/SVCSE-2984
Description
Updates the breach alerts email so that it can be compatible with autoscaling up and down based on queue size rather than run as a cron job. This required major pattern changes to how the job was invoked.
I refactored the job so that the pubsub subscription handling logic was separated from the business logic/processing for each message. I also updated the job to use DI pattern for easier testing. Much of the core message processing logic was lifted, with some streamlining around db checks. Since this was such a big overhaul I included some low-hanging fruit (removing premium upsell [5108] and removing the nimbus integration [5081]).
All the methods are unit-tested except for the main
jobentrypoint, which I had originally tried to cover with an integration test but couldn't run injsdomenvironment because pubsub client requiressetImmediate, etc. I tested this locally successfully and will do a dev deployment.Other Changes