Skip to content

MNTOR-5112: Don't react to feature flags in PlusBanner itself #6299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MNTOR-5112: Don't react to feature flags in PlusBanner itself #6299

wants to merge 1 commit into from
+0 −7

Conversation

@Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Nov 24, 2025

References:

Jira: MNTOR-5112
Figma:

Description

Followup to #6284.

Since 4882e23, shutdownState is directly controlled by the feature flags, so we no longer need to check for them in the component itself. (The component also only checked for the ShutdownBanner feature flag, meaning that disabling that would also disable the PostShutdownBanner.)

(Not a huge issue, since we probably won't disable that banner, but better safe than sorry.)

How to test

Disable the ShutdownBanner flag while keeping PostShutdownBanner. A Plus user should still see the banner.

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug. - I guess this is an integration bug...
  • If this PR implements a feature flag or experimentation, I've checked that it still works with the flag both on, and with the flag off.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@Vinnl
Don't react to feature flags in PlusBanner itself
b6b8da0 
Since 4882e23, `shutdownState` is
directly controlled by the feature flags, so we no longer need to check
for them in the component itself. (The component also only checked for
the `ShutdownBanner` feature flag, meaning that disabling that would
also disable the `PostShutdownBanner`.)
@Vinnl Vinnl requested a review from codemist November 24, 2025 13:29
@Vinnl Vinnl self-assigned this Nov 24, 2025
@Vinnl Vinnl added the Review: µ Code review time: 5 minutes or less label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codemist codemist codemist approved these changes

Assignees

@Vinnl Vinnl

Labels

Review: µ Code review time: 5 minutes or less

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Vinnl @codemist