feat(o11y): send manually logged server errors to Sentry #6347
+25
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschelonka
changed the title
kschelonka
changed the title
Vinnl
approved these changes
Dec 15, 2025
Collaborator
Author
|
It's not in the diff, but the sentryTransports includes transports.Console(). I realized there was a redundant if statement from the old pattern so I just updated it, which should also make it clearer |
kschelonka
commented
Dec 15, 2025
| level: "info", | ||
| transports: sentryTransports, | ||
| // In GCP environments, use cloud logging instead of stdout. | ||
| // FIXME https://mozilla-hub.atlassian.net/browse/MNTOR-2401 - enable for stage and production |
Collaborator
Author
There was a problem hiding this comment.
this is from before but it's showing up as new in the diff
Collaborator
Author
|
I'm going to wait on merging this until after the 17th when we're more nimble. Likely we will want to do follow-up releases to adjust alert levels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
[MNTOR-5173]
Description
If Sentry is initialized, add a Sentry transport to winston server logger. This will automatically forward any error-level logs to Sentry. There are currently application errors that are sent to GCP logging but not Sentry, so we aren't always alerted.
Follow-up work will be to audit and review errors as they come up, determining if the errors are informative, actionable, and appropriately leveled.