Remove unused/deprecated deploy jobs#6355
Conversation
mansaj
left a comment
There was a problem hiding this comment.
Looks like the v1 files are deleted and v2 files renamed to the v1 filename, right?
|
As a follow-up, there's more dockerhub uploads in other jobs (like the cron prerelease) which can be removed. I have suggestions for using reusable workflows/actions to deduplicate as well, but was waiting until our retro on deployment in the new year to discuss more. I'm aligned with removing all dockerhub if you want to get started on it. |
There was a problem hiding this comment.
Sorry I was premature, merging this will probably break 1-click deployment. Need to remove dockerhub from there
https://github.com/mozilla/blurts-server/blob/main/.github/workflows/production_deploy.yml#L65
18daf48 to
a4d8592
Compare
|
I went ahead and fixed the 1-click deployment and tested it on dev successfully: https://github.com/mozilla/blurts-server/actions/runs/20975476308 Going to get this in so we free this file up for further build changes. |
|
Thanks Kat! |
As per @mansaj: