-
Notifications
You must be signed in to change notification settings - Fork 75
Added custom pre-commit hook #2499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@suhaibmujahid could you please take a look at this PR |
Removed installation of test requirements from the task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to create a custom hook? Have you tried finding an off-the-shelf solution?
| hooks: | ||
| - id: check-json-indentation | ||
| name: Check JSON Indentation Consistency | ||
| entry: pre-commit/check_json_indentation.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there isn't an existing hook for this, it would be simpler to use an inline pygrep hook.
Custom pre-commit hook to ensure indentation consistency of JSON files. Resolves #2332
Checklist
to-be-announcedtag added if this is worth announcing