-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Service Worker Integration #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mrjman
wants to merge
16
commits into
main
Choose a base branch
from
feature/service-worker-poc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for build-a-b canceled.
|
2384e02 to
07a3684
Compare
… to register service worker under correct scope to work within the next web app
…equired for videos to work with service worker cache files
…ader to the root domain for files within public assets game. Using full path the sw.js did not work so this uses a more lenient wildcard which does work and should be fine
…nce the game is built in the prebuild step and building it here as well was causing an issue with the new service worker sw.js file
…udio webm files. update cache strategy to ignore header and url differences and set cache names to consistent convention and add a version that can be changed easily
… for vs, data war, and winner to service worker to store in runtime cache
… with Cache-Control header for service worker js file in netlify.toml configuration
…iles to avoid warnings and fix js variable not found issue in install listener
…se netlify.toml did not work properly
…er animations" This reverts commit 0a84f3a.
This reverts commit 3ecf542.
07a3684 to
32b56d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very much WIP
Whats this PR do?