feat: opacity annotations (opaque + transparent-typedef) - #1183
Open
nullstalgia wants to merge 27 commits into
Open
nullstalgia wants to merge 27 commits into
nullstalgia wants to merge 27 commits into
Conversation
(required for the following commit fixing a Clippy lint)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add two new per-struct annotations, providing more granular control over the "opacity"/external representation of types defined in Rust that get emitted by cbindgen.
transparent-typedef- (update of Add support for transparent typedefs (take 2) #1029)but there may be limits to what I can answer confidently.
opaquereprattributes present.pub typetypedefs, as to not affect intentionally-emitted structs containing said typedefs.#[repr(C)]types #24's variant of this request, but doesn't prevent another PR adding anopaque-sizedattribute or similar in the future.I've also cobbled together a test that ensures the two interact in a sane manner. Let me know if there are edge cases I haven't considered, in the tests or otherwise!
Thanks in advance.