Skip to content

feat(ci): run build and push workflow on labelled pull requests, exclude prs from forks #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlactin merged 8 commits into from
Jun 13, 2025
Merged

feat(ci): run build and push workflow on labelled pull requests, exclude prs from forks #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
10f2f20
feat(ci): run build and push workflow on labelled pull requests, excl…
dlactin Jun 5, 2025
f88a848
fix(build-and-push-images): using github.event.pull_request.head.sha …
dlactin Jun 5, 2025
67aa469
Merge branch 'main' into test-preview-env
dlactin Jun 11, 2025
ae5f62c
test: updating text for preview env test
dlactin Jun 12, 2025
8068ce2
fix: adding pr image_tag to mozcloud tag step
dlactin Jun 12, 2025
3b5f2ef
fix: adding pr image_tag to mozcloud tag step
dlactin Jun 12, 2025
1fa4cbb
chore: reverting custom pr config in mozcloud tag step
dlactin Jun 13, 2025
97f4d72
fix: using pull_request.head.sha for checkout on PR events
dlactin Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/build-and-push-images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name: Go Demo -- Build and Push Container Image to GAR

on:
pull_request:
types: [labeled, unlabeled, synchronize]
push:
branches:
- main
Expand All @@ -16,6 +18,14 @@ env:

jobs:
build-and-push:
if: >
github.event_name == 'push' ||
github.event_name == 'workflow_dispatch' ||
(
github.event_name == 'pull_request' &&
contains(github.event.pull_request.labels.*.name, 'preview') &&
github.event.pull_request.head.repo.full_name == github.repository
Copy link
Copy Markdown
Contributor

@grahamalama grahamalama Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a guard to ensure this isn't triggered on branches?

Copy link
Copy Markdown
Contributor Author

@dlactin dlactin Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a guard to avoid creating preview environments from forks, there might be a better solution for that though

)
runs-on: ubuntu-latest
permissions:
contents: read
Expand All @@ -25,6 +35,7 @@ jobs:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
with:
fetch-tags: true
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.ref }}
- uses: docker/setup-buildx-action@b5ca514318bd6ebac0fb2aedd5d36ec1b5c232a2
- id: gcp-auth
name: Google authentication
Expand Down Expand Up @@ -57,12 +68,14 @@ jobs:
else
tag="$(git rev-parse --short=10 HEAD)"
fi

# append metadata if present
if [[ -n "${{ env.METADATA }}" ]]; then
tag="${tag}--${{ env.METADATA }}"
fi

echo "Setting IMAGE_TAG=${tag} as output"
echo "IMAGE_TAG=${tag}" >> "$GITHUB_OUTPUT"
echo "IMAGE_TAG=${tag}" >> "$GITHUB_OUTPUT"
- name: Docker meta
id: meta
uses: docker/metadata-action@902fa8ec7d6ecbf8d84d538b9b233a880e428804
Expand All @@ -83,3 +96,4 @@ jobs:
push: true
cache-from: type=gha
cache-to: type=gha,mode=max

2 changes: 1 addition & 1 deletion go-demo/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func main() {
})

http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
w.Write([]byte("Welcome to the cicd demo web app! Visit /__version__ for version information."))
w.Write([]byte("Welcome to the cicd demo go web app! Visit /__version__ for version information. Adding test string here"))
})

port := "8000"
Expand Down