Make AGC settable by param and avoid Studio Display with VPIO #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Apple AGC has been observed to not amplify an overall low-volume input signal (e.g. when the device has a volume control in hw). Perhaps that is good enough for most cases. We'd rather make sure that if AGC is requested we only apply one AGC algorithm, and if no AGC is requested we do not apply any AGC algorithm.
``` error: the item `atomic` is imported redundantly --> src/backend/mod.rs:35:5 | 35 | use atomic; | ^^^^^^ | ::: src/lib.rs:6:1 | 6 | extern crate atomic; | -------------------- the item `atomic` is already imported here ```
padenot
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and some more minor changes, commits are pretty self explanatory.