Use a context-global shared VPIO unit #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pehrsons
force-pushed
the
reusable-vpio-serialize
branch
from
76fe402 to
186056e
Compare
Pehrsons
force-pushed
the
reusable-vpio-serialize
branch
from
186056e to
ca1650d
Compare
It allows at most one vpio duplex stream per context, which is hopefully enough for all real-world use cases. Note that Gecko could create at most one duplex stream per document, and there could in theory be multiple documents per context, which is a content process singleton.
Creating the vpio unit takes a long time. This commit lets clients create the shared vpio unit async on a background thread ahead of time, so that when they need it it is already available for reuse.
For input there could be a an output stream if vpio is present on the machine.
Pehrsons
force-pushed
the
reusable-vpio-serialize
branch
from
ca1650d to
5c3ec7e
Compare
padenot
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shared VPIO unit gets created on the first creation of a duplex stream. It will be used by any request for a duplex VOICE stream, if allowed and possible given the requested devices. With this PR there cannot be two VPIO units for a given context.