Skip to content
This repository was archived by the owner on Nov 10, 2017. It is now read-only.

Allow links in reason text#33

Open
reuben wants to merge 2 commits intomozilla:masterfrom
reuben:master
Open

Allow links in reason text#33
reuben wants to merge 2 commits intomozilla:masterfrom
reuben:master

Conversation

@reuben
Copy link

@reuben reuben commented Mar 6, 2013

Currently the reason text is escaped and shows as <a href…

@edmorley
Copy link
Contributor

edmorley commented Mar 6, 2013

We'll need to preserve the use case mentioned in bug 846868 before we merge this.

@catlee
Copy link
Contributor

catlee commented Mar 6, 2013

As long as tbpl is getting the reasons/motd via the API and not via the
rendered HTML, we should be able to linkify treestatus' UI, right?

On Wed, Mar 6, 2013 at 8:42 AM, Ed Morley notifications@github.com wrote:

We'll need to preserve the use case mentioned in bug 846868 before we
merge this.


Reply to this email directly or view it on GitHubhttps://github.com/catlee/treestatus/pull/33#issuecomment-14499664
.

@edmorley
Copy link
Contributor

edmorley commented Mar 6, 2013

That's not the use case; sheriffs repopulating the treestatus UI using old statuses is.

@reuben
Copy link
Author

reuben commented Mar 6, 2013

A better solution would be to have a "restore" button next to statuses, but we could not linkify if the user is a sheriff. Is that OK?

@edmorley
Copy link
Contributor

edmorley commented Mar 6, 2013

A restore button sgtm :-)

@reuben
Copy link
Author

reuben commented Mar 7, 2013

Looks like this: http://cl.ly/image/1m033f3V3k1a
I decided to just populate the fields since that allows sheriffs to edit it before setting the status.

@edmorley
Copy link
Contributor

edmorley commented Mar 7, 2013

That looks great :-)

I don't have permissions on this repo (and catlee will need to sign off anyway), so I'll leave the rest to him.

Thank you for doing this!

@catlee
Copy link
Contributor

catlee commented Apr 5, 2013

If bleach is a pure python library, then it should be put into the vendor lib. Does it have any compiled libraries?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants