This repository was archived by the owner on Nov 10, 2017. It is now read-only.
Bug 931542 - Make json logs also return tags#59
Open
KWierso wants to merge 2 commits intomozilla:masterfrom
Open
Bug 931542 - Make json logs also return tags#59KWierso wants to merge 2 commits intomozilla:masterfrom
KWierso wants to merge 2 commits intomozilla:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
is this part necessary given that to_dict() sets tags?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this works. I've played around with it locally and everything I've tested seems to work and doesn't break.
It's been a looong time since I've had to care about DB stuff, so hopefully I got everything right.