Skip to content

remove legacy table updates #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jaredsnyder
Copy link
Contributor

Checklist for reviewer:

  • Commits should reference a bug or github issue, if relevant (if a bug is
    referenced, the pull request should include the bug number in the title)
  • Scan the PR and verify that no changes (particularly to
    .circleci/config.yml) will cause environment variables (particularly
    credentials) to be exposed in test logs
  • Ensure the container image will be using permissions granted to
    telemetry-airflow
    responsibly.

@jaredsnyder
Copy link
Contributor Author

@m-d-bowerman
Copy link
Contributor

Looks good. Merging this is blocked by a view to create a replacement table, correct?

Copy link
Contributor

@m-d-bowerman m-d-bowerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Let's connect with Sydney this week re: requirements for the replacement view for Suggest forecasting and I'll raise that bq-etl PR.

@jaredsnyder
Copy link
Contributor Author

Looks good. Merging this is blocked by a view to create a replacement table, correct?

@m-d-bowerman Yeah I need to work with Sydney and Sergio to test the view from the notebook, it should be the same except the difference in where it starts so maybe I'm overthinking it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants