Add telemetry events #152

jonathanmendez · 2025-11-17T13:50:32Z

Enable enterprise pings
Add enterprise metrics
Enable (via cherry-picking Enterprise glean client #158 ) sending telemetry to configured console (currently hardcoded to enterfox)

…flag

… telemetry

…metry sending Changes sendingEnabled() to check AppConstants.MOZ_TELEMETRY_REPORTING instead of Services.telemetry.isOfficialTelemetry. This aligns with the conceptual separation of MOZILLA_OFFICIAL (official Mozilla build) from MOZ_TELEMETRY_REPORTING (telemetry transmission enabled), allowing for more granular control over telemetry behavior. Fixes the issue where "upload is turned off" was incorrectly shown in builds with MOZ_TELEMETRY_REPORTING enabled but MOZILLA_OFFICIAL disabled.

…NG config - Reset telemetry.fog.test.localhost_port to 0 (default) - Use MOZ_TELEMETRY_REPORTING instead of MOZILLA_OFFICIAL for glean upload control - Expose MOZ_TELEMETRY_REPORTING as config variable for build system access

- Create new enterprise ping definition in browser/components/downloads/pings.yaml - Move both file_downloaded and security_download_completed events to enterprise ping - Consolidate all download telemetry events in browser component metrics.yaml - Register enterprise ping in glean metrics_index.py for Firefox Desktop - Add GleanPings.enterprise.submit() calls to actually send the ping - Remove duplicate telemetry event definitions from toolkit component This separates enterprise security telemetry from the general events ping, providing better data organization and privacy controls.

PathUtils is available as a WebIDL global binding in Firefox, not as an ES module. Removed the ChromeUtils.importESModule call and fallback code since PathUtils is always available in this context.

jonathanmendez · 2025-11-21T04:15:54Z

browser/components/downloads/DownloadsCommon.sys.mjs

    );

+    // DEBUG: Enhanced logging for download telemetry debugging
+    console.log(`[DownloadsCommon] _notifyDownloadEvent called with aType: ${aType}, download: ${download ? 'present' : 'null'}, succeeded: ${download?.succeeded}`);


Should we remove the console.log debugging as part of the PR?

Yeah that can all be reduced to the minimum, a lot of this was tracing to see where things were going.

browser/components/downloads/DownloadsTelemetry.enterprise.sys.mjs

jonathanmendez · 2025-11-21T04:21:01Z

browser/components/downloads/metrics.yaml

+          The download source URL. Collection level configurable via enterprise
+          policy DownloadTelemetryUrlLogging: "full" (default), "domain", or "none".
+        type: string
+  security_download_completed:


@gcp What's the difference between the two metrics file_downloaded and security_download_completed?

The name.

...which allowed me to see which Firefox code was actually triggering the submission when I was debugging this.

We may not need two, but I vaguely remember that one of these actually triggers when initiating a download, and the other when it completes. In that case, we can keep them with some renaming.

jonathanmendez · 2025-11-21T04:22:22Z

browser/components/downloads/pings.yaml

+---
+$schema: moz://mozilla.org/schemas/glean/pings/2-0-0
+
+enterprise:


Should this file belong somewhere else? Perhaps browser/components/enterprise (despite there not being any metrics there)

jonathanmendez · 2025-11-21T04:39:47Z

toolkit/components/telemetry/pingsender/pingsender.cpp

 bool IsValidDestination(std::string aHost) {
  static const std::string kValidDestinations[] = {
      "localhost",
+      "127.0.0.1",


Remove (was it just for debugging/testing)?

jonathanmendez · 2025-11-21T04:41:08Z

toolkit/crashreporter/client/app/src/glean.rs

+    if cfg!(mock) {
+        "https://incoming.glean.example.com".to_string()
+    } else {
+        std::env::var("TELEMETRY_ENDPOINT")


Does this need to change with the updates from #158 ?

Yes, this can all go in favor of @fiji-flo's patch.

jonathanmendez · 2025-11-21T04:47:00Z

toolkit/mozapps/defaultagent/Telemetry.cpp

 #include "nsStringFwd.h"

-#define TELEMETRY_BASE_URL "https://incoming.telemetry.mozilla.org/submit"
+#define TELEMETRY_BASE_URL_DEFAULT "https://incoming.telemetry.mozilla.org/submit"


Change the implementation of this file based on #158 and #168 ?

jonathanmendez · 2025-11-21T04:48:39Z

toolkit/mozapps/extensions/AddonManager.sys.mjs

      })
    );
+#ifdef MOZ_ENTERPRISE
+    GleanPings.enterprise.submit();


Put behind pref check once added

Actually I'm not sure if there's a meaningful way to put this metric behind a pref check. The metric already exists and is sent regardless. Adding it to the enterprise ping seems to be a compile time decision. Avoiding submitting the enterprise ping here doesn't prevent it from being recorded and sent when the next enterprise ping is triggered. So just leave this as is?

~~Duplicate the ping, record it twice, make the enterprise recording conditional.~~

~~We could have the console pick up the regular ping for this, but as said, "event" pings are not "live" so this may not be what we want.~~

Edit: Wait, this doesn't make sense, does it? We already get this through normal Glean Telemetry and it's on by default, so we can just leave this here to get the "live" update.

jonathanmendez · 2025-11-21T04:50:25Z

toolkit/xre/nsAppRunner.cpp

+        // it as a user pref so the rest of the startup code reads the
+        // overridden value. This allows `TELEMETRY_ENDPOINT` to control the
+        // `toolkit.telemetry.server` preference at runtime.
+        if (const char* telemetryEnv = PR_GetEnv("TELEMETRY_ENDPOINT")) {


Change/remove based on #158 and #168 ?

Yeah all the TELEMETRY_ENDPOINT logic can go now.

toolkit/components/printing/content/print.js

gcp · 2025-11-21T22:01:35Z

browser/components/downloads/DownloadsCommon.sys.mjs

    );

+    // DEBUG: Enhanced logging for download telemetry debugging
+    console.log(`[DownloadsCommon] _notifyDownloadEvent called with aType: ${aType}, download: ${download ? 'present' : 'null'}, succeeded: ${download?.succeeded}`);


Yeah that can all be reduced to the minimum, a lot of this was tracing to see where things were going.

gcp · 2025-11-21T22:04:02Z

browser/components/downloads/DownloadsTelemetry.enterprise.sys.mjs

+ *
+ * Configuration Options:
+ * - Enabled (boolean): Enable/disable download telemetry collection
+ * - UrlLogging (string): URL logging level with values:


I think this wants FileLogging as well, where there is an intermediate level that just logs the extension and MIME type.

browser/components/downloads/DownloadsTelemetry.enterprise.sys.mjs

gcp · 2025-11-21T22:16:12Z

browser/components/downloads/metrics.yaml

+        description: >
+          The MIME type of the downloaded file as reported by the server.
+        type: string
+      file_size:


Wonderfully inconsistent with the other ping 😢

gcp · 2025-11-21T22:17:08Z

browser/components/downloads/pings.yaml

+---
+$schema: moz://mozilla.org/schemas/glean/pings/2-0-0
+
+enterprise:


gcp · 2025-11-21T22:36:54Z

browser/extensions/newtab/lib/ActivityStream.sys.mjs

    {
      title: "Structured Ingestion telemetry server endpoint",
-      value: "https://incoming.telemetry.mozilla.org/submit",
+      getValue: () =>


Let's rip it out then!

gcp · 2025-11-21T22:38:44Z

toolkit/components/glean/src/init/viaduct_uploader.rs

 fn should_ohttp_upload(upload_request: &PingUploadRequest) -> bool {
-    !upload_request.body_has_info_sections
+    // Disabled OHTTP uploads for local testing
+    false


This is probably from my WIP. I think we want to drop all changes in these files and use @fiji-flo's patched viaduct uploader.

gcp · 2025-11-21T22:39:20Z

toolkit/components/printing/content/print.js

+    try {
+      const sourceUrl = this._processSourceUrl(this.activeURI);
+      const topSourceUrl = this._processSourceUrl(this.topCurrentURI);
+      Glean.printing.pagePrinted.record({


Page count sounds like something an admin wants to know.

gcp · 2025-11-21T22:41:00Z

toolkit/modules/moz.build

    "MOZ_JXL",
    "MOZ_SYSTEM_POLICIES",
    "MOZ_SELECTABLE_PROFILES",
+    "MOZ_ENTERPRISE",


Do we still need this now that other code defined MOZ_ENTERPRISE already?

gcp · 2025-11-21T22:46:21Z

toolkit/mozapps/extensions/AddonManager.sys.mjs

      })
    );
+#ifdef MOZ_ENTERPRISE
+    GleanPings.enterprise.submit();


~~Duplicate the ping, record it twice, make the enterprise recording conditional.~~

~~We could have the console pick up the regular ping for this, but as said, "event" pings are not "live" so this may not be what we want.~~

Edit: Wait, this doesn't make sense, does it? We already get this through normal Glean Telemetry and it's on by default, so we can just leave this here to get the "live" update.

gcp · 2025-11-22T21:03:30Z

browser/components/enterprisepolicies/Policies.sys.mjs

        "browser.",
        "datareporting.policy.",
        "dom.",
+        "enterprise.",


@jonathanmendez This one is confusing me, I don't think this patch adds any preferences under that prefix?

gcp · 2025-11-23T00:24:41Z

browser/components/downloads/pings.yaml

+  include_client_id: false
+  send_if_empty: false
+  metadata:
+    include_info_sections: true


@fiji-flo @jonathanmendez This adds a bunch of junk to the pings:

{ "client_info": { "app_build": "20251123004502", "app_channel": "default", "app_display_version": "147.0a1", "architecture": "aarch64", "build_date": "1970-01-01T00:00:00+00:00", "first_run_date": "2025-11-06+01:00", "locale": "en-US", "os": "Darwin", "os_version": "25.1.0", "telemetry_sdk_build": "66.1.1" }, "events": [ { "category": "downloads", "extra": { "extension": "exe", "filename": "setupDeepSjengWC2008(1).exe", "glean_timestamp": "1763857152212", "is_private": "false", "mime_type": "application/octet-stream", "size_bytes": "1042621", "source_url": "https://sjeng.org/dl/setupDeepSjengWC2008.exe" }, "name": "download_completed", "timestamp": 0 } ], "ping_info": { "end_time": "2025-11-23T01:19:12.214+01:00", "experiments": { "ai-chatbot-page-summarization-mvp-treatment-a-callout-badge-rollout-v2": { "branch": "treatment-a-callout-badge", "extra": { "type": "nimbus-rollout" } }, "fx-accounts-ping-release-rollout-2": { "branch": "control", "extra": { "type": "nimbus-rollout" } }, "smart-tab-groups-rollout-beta": { "branch": "smart-tab-groups", "extra": { "type": "nimbus-rollout" } } }, "seq": 16, "start_time": "2025-11-23T01:19:11.000+01:00" } }

Specifically client_info and ping_info. I mean client_info isn't entirely useless but we expect to already have this as part of posture, and this data is now in every ping. Can't we fix the console to handle the absence of these?

- Move pings.yaml from browser/components/downloads to browser/components/enterprisepolicies (it's a shared enterprise ping used by multiple components) - Update metrics_index.py to reflect new pings.yaml location - Align download metric field naming (extension, size_bytes) across both metrics - Add data_sensitivity: highly_sensitive to enterprise metrics for consistency All other review comments were already addressed in earlier rebased commits.

gcp and others added 23 commits November 20, 2025 11:28

WIP

3b4a633

feat: add enterprise download security telemetry with MOZ_ENTERPRISE …

e38d646

…flag

feat: add enterprise download telemetry with policy controls

ea2854a

chore: update Cargo.lock

e7f5908

feat: add TELEMETRY_ENDPOINT env var support for telemetry endpoints

02f5632

refactor: unify TELEMETRY_ENDPOINT handling across components

61dd192

refactor: use lazy loading for DownloadsTelemetry

3205509

feat: add localhost support for telemetry testing and debugging

4caf74b

feat: prioritize TELEMETRY_ENDPOINT env var over localhost config

274abf1

feat: add debug logging for download telemetry

150fcc7

fix: Improve error handling and resource path resolution in downloads…

038925f

… telemetry

feat: wrap file_downloaded telemetry in MOZ_ENTERPRISE ifdef

47cea1a

fix: use PathUtils as global instead of importing as ES module

ca80612

PathUtils is available as a WebIDL global binding in Firefox, not as an ES module. Removed the ChromeUtils.importESModule call and fallback code since PathUtils is always available in this context.

POC metric for page printed

6997c65

Update metric to have better data

19b231e

Put print telemetry behind #ifdef MOZ_ENTERPRISE

72a29ea

Add and check prefs for metric

f824376

Add content titles to print metric payload

384b4a4

Add existing add-on install metric to enterprise pings

e6a22fb

Include info section in enterprise ping so console can consume

f98868d

jonathanmendez force-pushed the add-more-telemetry-events branch from 797e0e6 to c2bbf23 Compare November 20, 2025 17:40

jonathanmendez temporarily deployed to Credentials November 20, 2025 17:40 — with GitHub Actions Inactive

jonathanmendez temporarily deployed to Credentials November 20, 2025 17:47 — with GitHub Actions Inactive

jonathanmendez had a problem deploying to Credentials November 20, 2025 17:47 — with GitHub Actions Failure

jonathanmendez temporarily deployed to Credentials November 20, 2025 17:47 — with GitHub Actions Inactive

Jonathan Mendez and others added 2 commits November 20, 2025 14:39

Allow enterprise prefix policies to be set via policy

da7695d

Enterprise glean client

0bd4adb

jonathanmendez force-pushed the add-more-telemetry-events branch from c2bbf23 to 0bd4adb Compare November 20, 2025 22:50

jonathanmendez temporarily deployed to Credentials November 20, 2025 22:50 — with GitHub Actions Inactive

Add metric for browsing a blocked URL

6ee43ad

jonathanmendez temporarily deployed to Credentials November 20, 2025 22:52 — with GitHub Actions Inactive

jonathanmendez temporarily deployed to Credentials November 20, 2025 22:59 — with GitHub Actions Inactive

jonathanmendez had a problem deploying to Credentials November 20, 2025 22:59 — with GitHub Actions Failure

jonathanmendez temporarily deployed to Credentials November 20, 2025 22:59 — with GitHub Actions Inactive

jonathanmendez temporarily deployed to Credentials November 20, 2025 23:01 — with GitHub Actions Inactive

jonathanmendez had a problem deploying to Credentials November 20, 2025 23:01 — with GitHub Actions Failure

jonathanmendez commented Nov 21, 2025

View reviewed changes

Remove debugging force-enable of download telemetry

f3bf7a2

jonathanmendez commented Nov 21, 2025

View reviewed changes

toolkit/components/printing/content/print.js Show resolved Hide resolved

Jonathan Mendez added 6 commits November 21, 2025 10:18

Add policy and pref for telemetry of browsing blocked domains

65185b4

Protect against telemetry exceptions for printing

2090a56

Protect against telemetry exceptions during website filtering

eaaa96a

Add BlocklistDomainBrowsedTelemetry policy to schema

9b74d2f

Revert defunct changes to redirect telemetry

9e4617a

Remove defunct cargo dependency on local glean

d72789d

gcp requested changes Nov 21, 2025

View reviewed changes

Jonathan Mendez added 2 commits November 21, 2025 17:26

Remove obsolete pref

7da0388

Remove trace log statements

4b6aecb

gcp reviewed Nov 22, 2025

View reviewed changes

gcp reviewed Nov 23, 2025

View reviewed changes

Add telemetry events #152

Are you sure you want to change the base?

Add telemetry events #152

Conversation

jonathanmendez commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gcp Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gcp Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonathanmendez commented Nov 17, 2025 •

edited

Loading

gcp Nov 21, 2025 •

edited

Loading

gcp Nov 21, 2025 •

edited

Loading