Add Enterprise Telemetry #183

gcp · 2025-11-23T00:32:39Z

No description provided.

…flag

… telemetry

…metry sending Changes sendingEnabled() to check AppConstants.MOZ_TELEMETRY_REPORTING instead of Services.telemetry.isOfficialTelemetry. This aligns with the conceptual separation of MOZILLA_OFFICIAL (official Mozilla build) from MOZ_TELEMETRY_REPORTING (telemetry transmission enabled), allowing for more granular control over telemetry behavior. Fixes the issue where "upload is turned off" was incorrectly shown in builds with MOZ_TELEMETRY_REPORTING enabled but MOZILLA_OFFICIAL disabled.

…NG config - Reset telemetry.fog.test.localhost_port to 0 (default) - Use MOZ_TELEMETRY_REPORTING instead of MOZILLA_OFFICIAL for glean upload control - Expose MOZ_TELEMETRY_REPORTING as config variable for build system access

- Create new enterprise ping definition in browser/components/downloads/pings.yaml - Move both file_downloaded and security_download_completed events to enterprise ping - Consolidate all download telemetry events in browser component metrics.yaml - Register enterprise ping in glean metrics_index.py for Firefox Desktop - Add GleanPings.enterprise.submit() calls to actually send the ping - Remove duplicate telemetry event definitions from toolkit component This separates enterprise security telemetry from the general events ping, providing better data organization and privacy controls.

PathUtils is available as a WebIDL global binding in Firefox, not as an ES module. Removed the ChromeUtils.importESModule call and fallback code since PathUtils is always available in this context.

lissyx · 2025-11-24T14:18:57Z

browser/components/downloads/DownloadsTelemetry.enterprise.sys.mjs

+  _isEnabled() {
+    return Services.prefs.getBoolPref(
+      "browser.download.enterprise.telemetry.enabled",
+      true


we default to enabled by default? ok

Mostly for debugging, can flip the default later on. We did enable the other stuff by default.

CrowdStrike knows your downloads anyway :P

lissyx · 2025-11-24T14:23:52Z

browser/components/downloads/metrics.yaml

    telemetry_mirror: DOWNLOADS_PANEL_SHOWN
+
+#ifdef MOZ_ENTERPRISE
+  download_completed:


do we need feedback from glean people on how we do this? not data review but making sure event is the correct way?

I already had this discussions about this part. An event works, but it's only live if it's not part of the normal (Firefox) events ping, which is why this needed a separate enterprise ping. Normal Firefox events are queued up to 500 and sent together. We don't want this for Enterprise to make the console a "live" view.

lissyx · 2025-11-24T14:28:35Z

browser/components/downloads/test/unit/xpcshell.toml

+# Only run in MOZ_ENTERPRISE builds
+skip-if = [
+  "!buildapp:firefox",
+  "!enterprise",


we have this mozinfo flag? good to know I'll use it for policies

I should probably test the non-enterprise build :P

lissyx · 2025-11-24T14:29:23Z

browser/components/enterprisepolicies/Policies.sys.mjs

  },

+  BlocklistDomainBrowsedTelemetry: {
+    onBeforeAddons(manager, param) {


nit: onRemove could be welcome :)

lissyx · 2025-11-24T14:29:47Z

browser/components/enterprisepolicies/Policies.sys.mjs

  },

+  PrintPageTelemetry: {
+    onBeforeAddons(manager, param) {


nit: onRemove would be welcome

lissyx · 2025-11-24T14:30:05Z

browser/components/enterprisepolicies/Policies.sys.mjs

  },

+  DownloadTelemetry: {
+    onBeforeAddons(manager, param) {


nit: onRemove would be welcome

lissyx · 2025-11-24T14:31:23Z

browser/components/newtab/test/browser/abouthomecache/browser.toml

  "browser.newtabpage.activity-stream.feeds.system.topstories=true",
  "browser.newtabpage.activity-stream.feeds.section.topstories=true",
  "browser.newtabpage.activity-stream.feeds.system.topstories=true",
-  "browser.newtabpage.activity-stream.telemetry.structuredIngestion=false",


why do we remove?

i would feel safer if we did this removal conditionnally on being an enterprise build

lissyx · 2025-11-24T14:34:02Z

toolkit/components/telemetry/app/TelemetrySend.sys.mjs

+    // We only send pings when telemetry reporting is enabled, but allow overriding this for tests.
    if (
-      !Services.telemetry.isOfficialTelemetry &&
+      !AppConstants.MOZ_TELEMETRY_REPORTING &&


might be worth scoping this only to enterprise builds?

I believe at some point we'll have our own distinction of official / non official builds?

lissyx · 2025-11-24T14:38:07Z

toolkit/mozapps/extensions/metrics.yaml

+#ifdef MOZ_ENTERPRISE
+    send_in_pings:
+      - enterprise
+      - default


why default ? isn't it always sent to in the default ping?

I hope the other events aren't :P

gcp and others added 30 commits November 22, 2025 21:40

WIP

9421be6

feat: add enterprise download security telemetry with MOZ_ENTERPRISE …

2b550e0

…flag

feat: add enterprise download telemetry with policy controls

8809673

chore: update Cargo.lock

c1320f0

feat: add TELEMETRY_ENDPOINT env var support for telemetry endpoints

f2d2f34

refactor: unify TELEMETRY_ENDPOINT handling across components

65a3b54

refactor: use lazy loading for DownloadsTelemetry

f4ea991

feat: prioritize TELEMETRY_ENDPOINT env var over localhost config

ce4144c

feat: add debug logging for download telemetry

a63c1a4

fix: Improve error handling and resource path resolution in downloads…

a2de78c

… telemetry

feat: wrap file_downloaded telemetry in MOZ_ENTERPRISE ifdef

14d45c0

fix: use PathUtils as global instead of importing as ES module

7424422

PathUtils is available as a WebIDL global binding in Firefox, not as an ES module. Removed the ChromeUtils.importESModule call and fallback code since PathUtils is always available in this context.

POC metric for page printed

b6ccae4

Update metric to have better data

46a4182

Put print telemetry behind #ifdef MOZ_ENTERPRISE

df91afa

Add and check prefs for metric

d69de77

Add content titles to print metric payload

e19eb0e

Add existing add-on install metric to enterprise pings

dd5339f

Include info section in enterprise ping so console can consume

ce37555

Allow enterprise prefix policies to be set via policy

c88d4ee

Add metric for browsing a blocked URL

d6ac473

Remove debugging force-enable of download telemetry

dfb579c

Add policy and pref for telemetry of browsing blocked domains

761023b

Protect against telemetry exceptions for printing

f296748

Protect against telemetry exceptions during website filtering

4fb474d

Add BlocklistDomainBrowsedTelemetry policy to schema

d74c637

Revert defunct changes to redirect telemetry

66b7494

gcp temporarily deployed to Credentials November 23, 2025 01:29 — with GitHub Actions Inactive

Enable enterprise download telemetry by default for local testing

1726c8b

gcp temporarily deployed to Credentials November 23, 2025 01:31 — with GitHub Actions Inactive

gcp temporarily deployed to Credentials November 23, 2025 01:32 — with GitHub Actions Inactive

gcp temporarily deployed to Credentials November 23, 2025 01:33 — with GitHub Actions Inactive

gcp temporarily deployed to Credentials November 23, 2025 01:38 — with GitHub Actions Inactive

Remove unused enterprise prefix from Preferences policy

9f6d06f

gcp force-pushed the pr152-review-fixes branch from 916526d to 9f6d06f Compare November 23, 2025 01:48

gcp temporarily deployed to Credentials November 23, 2025 01:48 — with GitHub Actions Inactive

gcp temporarily deployed to Credentials November 23, 2025 02:02 — with GitHub Actions Inactive

gcp temporarily deployed to Credentials November 23, 2025 02:03 — with GitHub Actions Inactive

gcp temporarily deployed to Credentials November 23, 2025 02:05 — with GitHub Actions Inactive

gcp temporarily deployed to Credentials November 23, 2025 02:06 — with GitHub Actions Inactive

gcp temporarily deployed to Credentials November 23, 2025 02:11 — with GitHub Actions Inactive

lissyx reviewed Nov 24, 2025

View reviewed changes

lissyx approved these changes Nov 24, 2025

View reviewed changes

Add Enterprise Telemetry #183

Are you sure you want to change the base?

Add Enterprise Telemetry #183

Conversation

gcp commented Nov 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gcp Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gcp Nov 24, 2025 •

edited

Loading