feat(nimbus): Improve funnel diagram#15933
Merged
Merged
Conversation
added 6 commits
June 11, 2026 10:25
…move hex map and comments
yashikakhurana
requested review from
freshstrangemusic,
jaredlockhart and
mikewilli
as code owners
Contributor
Author
|
added 5 commits
June 11, 2026 14:19
…correct SQL template
jaredlockhart
approved these changes
Jun 15, 2026
jaredlockhart
left a comment
jaredlockhart
left a comment
Collaborator
There was a problem hiding this comment.
Ya generally looks great. Couple little thoughts about organizing but nothing critical, new design looks fantastic I'm so stoked we have it now, great job thnx @yashikakhurana 🙏 🎉
Comment on lines
+1504
to
+1507
| from experimenter.experiments.monitoring_utils import ( | ||
| check_feature_conflict, | ||
| check_zero_enrollment, | ||
| ) |
Collaborator
There was a problem hiding this comment.
They have to be here for circular import?
| "type": "low_enrollment", | ||
| "label": f"Low Enrollment ({total:,})", | ||
| } | ||
| ) |
Collaborator
There was a problem hiding this comment.
Maybe we can move all these over to constants to keep them in one place?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #15903