Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(customs): Fix broken customs integration tests #18544

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

dschom
Copy link
Contributor

@dschom dschom commented Mar 12, 2025

Because

  • We updated the totpCodeRules.limit.max default value, but failed to update the corresponding test.

This pull request

  • Sets the max for totpCodeRules.limits to 2 since that's what test expects.

Issue that this pull request solves

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

Because:
- We updated the totpCodeRules.limit.max default value, but failed to update the corresponding test.

This Commit:
- Sets the max for totpCodeRules.limits to 2 since that's what test expects.
@dschom dschom requested a review from a team as a code owner March 12, 2025 19:29
@dschom dschom merged commit b0b36e0 into main Mar 12, 2025
4 of 5 checks passed
@dschom dschom deleted the fix-broken-customs-tests branch March 12, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants