chore(fxa-shared): Dedupe ConnectedServicesFactory builder #19593
+702
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: - There is a chance that ConnectedServicesFactory will return duplicate and/or null id connected devices This Commit: - Adds logic to dedupe records as they're built - And fixes a bug where a Map() was used with buffer values, resulting in it always allowing new records even if they were identical - And adds tests for the dedupe protection
nshirley
changed the title
nshirley
commented
Oct 27, 2025
| const result = await route(request); | ||
|
|
||
| assert.equal(result.length, 6); | ||
| console.debug('Result:', result); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This Commit:
Closes: FXA-12532
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.