Skip to content

Conversation

@elizabeth-ilina
Copy link
Contributor

@elizabeth-ilina elizabeth-ilina commented Oct 24, 2025

Because

  • 'with-accounts’ / ‘without-accounts’ should assess whether the customer had an account prior to checking out, or if they created a new account as part of the checkout process.

This pull request

  • If newAccount is present, new customer, return 'without-accounts'.
  • If newAccount is not present, loggedIn is true - not a new customer, return 'with-accounts'.
  • If newAccount is not present, loggedIn is false - customer is not logged in, and we don't know enough about them, so we report blank. --> NOT DONE YET!

Issue that this pull request solves

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3182-persist-with-accounts-or-without-accounts-metrics-throughout-checkout branch 8 times, most recently from 8328cca to c3c3874 Compare October 28, 2025 18:09
@elizabeth-ilina elizabeth-ilina marked this pull request as ready for review October 28, 2025 18:10
@elizabeth-ilina elizabeth-ilina requested a review from a team as a code owner October 28, 2025 18:10
@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3182-persist-with-accounts-or-without-accounts-metrics-throughout-checkout branch from c3c3874 to 2e9b698 Compare October 28, 2025 19:38
@elizabeth-ilina elizabeth-ilina marked this pull request as draft October 28, 2025 19:41
@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3182-persist-with-accounts-or-without-accounts-metrics-throughout-checkout branch from 2e9b698 to 5a48aac Compare October 28, 2025 19:54
…trics throughout checkout

Because:

*

This commit:

* Initial commit - ipr
@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3182-persist-with-accounts-or-without-accounts-metrics-throughout-checkout branch from 5a48aac to 6761f38 Compare October 28, 2025 20:07
@david1alvarez
Copy link
Contributor

Associated Data Review:
GitHub Issue link: #19677
Bugzilla report link: https://bugzilla.mozilla.org/show_bug.cgi?id=2000681

@david1alvarez
Copy link
Contributor

Hi @elizabeth-ilina, can you please update the glean metrics file to have the following definition for the subscription.checkout_type field?
libs/shared/metrics/glean/src/registry/subplat-backend-metrics.yaml

  checkout_type:
    type: string
    description: |
      Account status at time of checkout
    lifetime: application
    send_in_pings:
      - events
    notification_emails:
      - [email protected]
      - [email protected]
    bugs:
      - https://mozilla-hub.atlassian.net/browse/FXA-7531
      - https://mozilla-hub.atlassian.net/browse/PAY-3182
    data_reviews:
      - https://github.com/mozilla/fxa/issues/18512
      - https://github.com/mozilla/fxa/issues/19677
      - https://bugzilla.mozilla.org/show_bug.cgi?id=2000681
    expires: never
    data_sensitivity:
      - interaction

@david1alvarez
Copy link
Contributor

david1alvarez commented Nov 17, 2025

Data Review

1) What questions will you answer with this data?

The checkout_type will be used to associate checkout data with account login categories. Additional clarification is required beyond the current recorded data; we will use this field to describe whether the checkout is associated with a newly created account, a pre-existing account, no account, or similar categorizations of account statuses.

2) Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

It will allow mozilla products to understand how successfully they are reaching users with different account statuses. This will allow them to understand if their users are primarily new users, pre-existing users, or other account-status-level categorizations.

3) What alternative methods did you consider to answer these questions? Why were they not sufficient?

An alternative field could serve to help distinguish this, however there is no alternative pathway to answering this question. We are able to detect whether a customer is signed in to their account, but have no context for what their account's status is in checkout.

4) Can current instrumentation answer these questions?

No

5) List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug # Measurement Name
Account status at time of checkout interaction https://bugzilla.mozilla.org/show_bug.cgi?id=2000681 subscription.checkout_type

NB: This field is already being recorded following its approval in FXA issue 18512. This change affects the description, which was previously Whether the checkout flow is for new users or existing users. One of “with-account” or “without-account".

6) Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.

This collection is Glean so is documented in the Glean Dictionary

7) How long will this data be collected?

This collection will be collected permanently.
[email protected], [email protected] will be responsible for the permanent collections.

8) What populations will you measure?

All channels, countries, and locales. No filters.

9) If this data collection is default on, what is the opt-out mechanism for users?

These collections are Glean. The opt-out can be found in the account's preferences.

10) Please provide a general description of how you will analyze this data.

The checkout_type will be used to filter the checkout funnel based on the user's account status. We expect checkouts associated with newly created accounts, pre-existing accounts, no accounts, or other similar account statuses to be sufficiently different populations as to warrant separate analyses.

11) Where do you intend to share the results of your analysis?

This data will be used for creation of Looker dashboards.

12) Is there a third-party tool (i.e. not Glean or not Telemetry) that you are proposing to use for this data collection? If so:

No.

@chutten

@david1alvarez david1alvarez requested review from groovecoder and removed request for groovecoder November 17, 2025 19:56
@chutten
Copy link

chutten commented Nov 18, 2025

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through the product's preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, [email protected], [email protected] will be responsible for the permanent collections.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.


Result: datareview+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants