Skip to content

Conversation

@dschom
Copy link
Contributor

@dschom dschom commented Oct 25, 2025

Because

  • We will need this for subsequent efforts

This pull request

  • Ports oauth/errors.js and errors.js from auth-server to libs

Issue that this pull request solves

Closes: FXA-12581

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

This is a requirement for porting email sending code. Other PRs are based on this one.

@dschom dschom requested a review from a team as a code owner October 25, 2025 01:33
@dschom dschom marked this pull request as draft October 25, 2025 01:36
Because:
- We will need this for subsequent efforts

This commit:
- Ports `oauth/errors.js` and `errors.js` from auth-server to libs
@dschom dschom marked this pull request as ready for review October 27, 2025 17:04
Copy link
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dschom Was this ticket just for moving the code? Or were you planning on updating the calling code too?

@dschom
Copy link
Contributor Author

dschom commented Oct 27, 2025

@vbudhram It's just moving it. I didn't want this PR to block the email sending PRs that are based on this one. Updating auth-server (and settings) is filed as a separate ticket, FXA-12585.

@vpomerleau
Copy link
Contributor

Is there a follow-up issue to port/add tests such as packages/fxa-auth-server/test/local/error.js into this lib?

@dschom
Copy link
Contributor Author

dschom commented Oct 28, 2025

@vpomerleau I should do that here. I think I missed that file and it's a small lift. Thanks for flagging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants