chore(): upgrade NX to v21.2.4 #19604
Open
+544
−558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschom
reviewed
Oct 28, 2025
dschom
reviewed
Oct 28, 2025
package.json
Outdated
| "semver": "^7.7.1", | ||
| "set-value": "^4.1.0", | ||
| "sms-segments-calculator": "^1.2.0", | ||
| "storybook": "9.1.9", |
There was a problem hiding this comment.
Have you validated the storybooks still render correctly?
There was a problem hiding this comment.
Good call. I assumed the storybook tests would fail. They didn't, and yet visiting the Storybook links below looks broken. I'll try to revert this change.
There was a problem hiding this comment.
IIRC, we tried this at some point and ran into several problems. I think we have a ticket in our backlog to update this.
dschom
reviewed
Oct 28, 2025
toufali
force-pushed
the
upgrade-nx-21.2.4
branch
7 times, most recently
from
127eff0 to
f576887
Compare
toufali
force-pushed
the
upgrade-nx-21.2.4
branch
from
f576887 to
6ac3acb
Compare
|
Thanks for the review @dschom – addressed your comments and confirmed Storybook working as expected 👍 |
|
@toufali Thanks for the updates and the feedback. |
dschom
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-12577
Other information (Optional)
I tried bumping even further (21.3 and beyond) but these required bumping
@nx/jestwhich subsequently breaks our build due to deprecated methods.