feat(payments-next): Add expanded payment method metrics in statsd/yardstick #19684
+74
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabeth-ilina
force-pushed
the
PAY-3349-add-expanded-payment-method-metrics-in-statsd
branch
4 times, most recently
from
0366cfa to
c49bab8
Compare
elizabeth-ilina
force-pushed
the
PAY-3349-add-expanded-payment-method-metrics-in-statsd
branch
4 times, most recently
from
68cfb55 to
5fcb3cc
Compare
…rdstick Because: * We currently report stripe vs paypal subscription payments, but with the introduction of expanded payment methods, we should capture that breakdown in statsd/yardstick This commit: * Differentiates between different SubPlatPaymentMethodType when reporting the payment provider. Closes #PAY-3349
elizabeth-ilina
force-pushed
the
PAY-3349-add-expanded-payment-method-metrics-in-statsd
branch
from
5fcb3cc to
e392b28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #PAY-3349
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.