chore(fxa-shared): Connected Services Factory fetch bindings concurrently #19692
+22
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntly Because: - We currently fetch all sessions, devices, and oauthClients in series, and it can be slow This Commit: - Updates the ConnectedServicesFactory to fetch all bindings concurrently and passes results to merge - Updates authorized_clients.list to also fetch refresh and access tokens concurrently to match how other bindings get multiple data sources Closes: FXA-8613
nshirley
changed the title
nshirley
commented
Nov 21, 2025
| await oauthDB.ready(); | ||
| const authorizedClients = []; | ||
|
|
||
| const [refreshTokens, accessTokens] = await Promise.all([ |
Contributor
Author
There was a problem hiding this comment.
This is one place that is used as a binding for the ConnectedServicesFactory here in auth. Since I was updating the factory to fetch concurrently I figured it was worth updating this too. The other callbacks for the bindings do similar parallel fetches of data so this keeps it consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-8613
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.