chore(errors): additional cleanup for AppError/OauthError code #19758
+115
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshirley
changed the title
nshirley
approved these changes
Dec 15, 2025
Contributor
nshirley
left a comment
nshirley
left a comment
There was a problem hiding this comment.
I checked out all of the moved messages and made sure they didn't get any crossed wires! I also checked out the original PR and it looks like this addresses all of the outstanding things. r+ but up to you if you want Dan's 👀 too!
| DISABLED_CLIENT_ID: 202, | ||
| }; | ||
|
|
||
| export const OAUTH_ERROR_MESSAGES: Record<keyof typeof OAUTH_ERRNO, string> = { |
Contributor
There was a problem hiding this comment.
Smart use of the type constraint with OAUTH_ERRNO! I see it's used in the sharedError to allow indexing this and OAUTH_ERRNO with the same key value since they're from the same type!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-12747