tests(lib/emails): Add tests for lib/email renderer and sender #19775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshirley
commented
Dec 9, 2025
nshirley
commented
Dec 9, 2025
nshirley
commented
Dec 9, 2025
nshirley
commented
Dec 9, 2025
nshirley
commented
Dec 9, 2025
nshirley
commented
Dec 9, 2025
nshirley
force-pushed
the
FXA-12579
branch
2 times, most recently
from
52b34fb to
2bec955
Compare
dschom
reviewed
Dec 9, 2025
nshirley
commented
Dec 9, 2025
nshirley
commented
Dec 10, 2025
nshirley
commented
Dec 10, 2025
nshirley
force-pushed
the
FXA-12579
branch
2 times, most recently
from
a7d7f70 to
6c21f6f
Compare
nshirley
commented
Dec 10, 2025
libs/accounts/email-renderer/src/renderer/__snapshots__/fxa-email-renderer.spec.ts.snap
Show resolved
Hide resolved
dschom
reviewed
Dec 12, 2025
dschom
reviewed
Dec 12, 2025
dschom
reviewed
Dec 12, 2025
libs/accounts/email-renderer/src/templates/passwordResetAccountRecovery/index.txt
Show resolved
Hide resolved
dschom
reviewed
Dec 12, 2025
| @@ -1,11 +1,11 @@ | |||
| postChangeTwoStepAuthentication-title-2 = "Two-step authentication has been updated" | |||
Contributor
There was a problem hiding this comment.
I find this suffixes a little suspicous... Do when know when/why they were added?
Contributor
Author
There was a problem hiding this comment.
It looks like it was added here, but it wasn't referenced correctly so maybe it's been broken all this time? (candidly, I haven't really gotten to learn how the l10n stuff works so I could be missing something)
dschom
reviewed
Dec 12, 2025
dschom
approved these changes
Dec 12, 2025
Contributor
dschom
left a comment
dschom
left a comment
There was a problem hiding this comment.
These changes look great. I'm a big fan of the snapshot approach over the what we had before.
nshirley
force-pushed
the
FXA-12579
branch
2 times, most recently
from
e8d2f8d to
2c407c1
Compare
4 tasks
dschom
reviewed
Dec 15, 2025
dschom
reviewed
Dec 15, 2025
Because: - Moving/re-architecting email code to libs/ meant we needed new tests This pull request: - Adds tests for libs/accounts/email-renderer and libs/accounts/email-sender Closes: FXA-12579
Contributor
Author
|
Last two force pushes after approval were for cleaning up error/rejection tests and amending commit message to follow requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-12579
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.