fix(payments): Fix validation for paymentProvider #19777
Draft
+28
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlisachan
force-pushed
the
polish_checkout-form
branch
2 times, most recently
from
e9da02a to
69b630f
Compare
xlisachan
changed the title
Because - Sentry events frequently occur for the CheckoutForm component as it is a client component, but it is importing the Node server SDK for Stripe causing Next to try to bundle Stripe Node SDK into the client build and surface the Server Components render error - Validation for paymentProvider was expecting an enum This pull request - Updates import for Stripe to import type-only since we are only using Stripe for Stripe.PaymentMethod.Type - Updates to use SubPlatPaymentMethodType instead of PaymentProvidersType Closes - PAY-3439
xlisachan
force-pushed
the
polish_checkout-form
branch
from
69b630f to
a8c7c95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Stripe.PaymentMethod.TypeIssue that this pull request solves
Closes: PAY-3439
Checklist
Put an
xin the boxes that apply