Skip to content

Conversation

@MagentaManifold
Copy link
Contributor

Because

  • create_password page does not have MFA

This pull request

  • adds MFA to create_password page

Issue that this pull request solves

Closes: FXA-12741

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@MagentaManifold
Copy link
Contributor Author

It looks like:

  • There's no GQL endpoint for password create, so there's nothing to update there
  • There's no functional test for the create_password page, and there's no way to functional test it at all since it involves signing in with third party auth

@MagentaManifold MagentaManifold marked this pull request as ready for review December 10, 2025 21:01
@MagentaManifold MagentaManifold requested a review from a team as a code owner December 10, 2025 21:01
@MagentaManifold MagentaManifold force-pushed the FXA-12741 branch 3 times, most recently from eb39ba4 to 98fa18d Compare December 11, 2025 21:19
Because:

* create_password page does not have MFA

This commit:

* adds MFA to create_password page

Closes FXA-12741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants