Skip to content

task(admin): Support secret rotation for RPs #19788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dschom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

task(admin): Support secret rotation for RPs #19788

dschom wants to merge 1 commit into from
+664 −74

Conversation

@dschom
Copy link
Contributor

@dschom dschom commented Dec 11, 2025 •
edited
Loading

Because

  • We want to support management of RP's client secrets

This pull request

  • Allows us to rotate a client secret
  • Preserves the previous secret, so that rotation is not disruptive
  • Let's us revoke the previous secret, once the new secret has been validated
  • Warns user if they are about to rotate over an existing previous secret

Issue that this pull request solves

Closes: FXA-12703

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

image image image image image image

Other information (Optional)

Any other information that is important to this pull request.

@dschom dschom requested a review from a team as a code owner December 11, 2025 23:26
vpomerleau
vpomerleau reviewed Dec 12, 2025
View reviewed changes
vpomerleau
vpomerleau reviewed Dec 13, 2025
View reviewed changes
Copy link
Contributor

@vpomerleau vpomerleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small nits, except the for question around AuditLog decorator

@dschom dschom force-pushed the FXA-12703 branch 4 times, most recently from 1792d35 to cd53c40 Compare December 15, 2025 19:40
@dschom
Copy link
Contributor Author

dschom commented Dec 15, 2025

Mostly small nits, except the for question around AuditLog decorator

@vpomerleau I've checked the audit log decorator and adjusted accordingly.

@vpomerleau
Copy link
Contributor

vpomerleau commented Dec 15, 2025

Approved, pending small build issue fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpomerleau vpomerleau vpomerleau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dschom @vpomerleau