Skip to content

Conversation

@dschom
Copy link
Contributor

@dschom dschom commented Dec 12, 2025

Because

  • Diagnostic code can be null in the database
  • We recently fixed a different bug, where inserts were failing because were providing undefined instead null, hence null values are now being written.

This pull request

  • Fixes the schema to support nullable values.

Issue that this pull request solves

Closes: FXA-127896

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Before:
image

After:
image

Other information (Optional)

Any other information that is important to this pull request.

@dschom dschom requested a review from a team as a code owner December 12, 2025 20:13
@dschom dschom merged commit 4653dd1 into main Dec 15, 2025
19 checks passed
@dschom dschom deleted the FXA-12786 branch December 15, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants