task(admin): Fix bug if x-forward-for has multiple values #19792
+46
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshirley
approved these changes
Dec 12, 2025
Contributor
nshirley
left a comment
nshirley
left a comment
There was a problem hiding this comment.
Just a question about v4 vs v6 syntax - though maybe out of scope for the changes since, the bug looks to be resolved!
| describe('sanitizes ip address', () => { | ||
| it('handles multiple ips', () => { | ||
| const ip = sanitizeIp(' 127.0.0.1, 127.0.0.2'); | ||
| assert.equal(ip, '::127.0.0.1'); |
Contributor
There was a problem hiding this comment.
I guess related to my question above about v4 and v6 should this start with a double ::? From what I read the :: is valid in v6, but only when compressing a 16-bit group of zeros (0:0:0:0:0:0). Feels like we don't really need to "prefix" the :: on there at all
Contributor
Author
There was a problem hiding this comment.
My research showed it's valid, but 'deprecated'. I mostly just didn't want to change the logic here. I feel like if we want to do this it should be a separate PR just on the off chance we need to roll it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-12755
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.