fix(type): Allow FxAStatusResponse to be undefined #19793
+22
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: * According to some Sentry events, message.data (FxAStatusResponse) can be undefined This commit: * Updates the response to better match potential runtime behavior to enforce undefined checks closes FXA-12760
vpomerleau
reviewed
Dec 15, 2025
| service: Constants.SYNC_SERVICE, | ||
| }); | ||
| if (!webChannelEngines && status.capabilities.engines) { | ||
| if (!webChannelEngines && status?.capabilities.engines) { |
Contributor
There was a problem hiding this comment.
Should we set defaults and return early when status and/or status.capabilities are undefined?
E.g.,
const DEFAULT_CAPABILITIES = {
engines: [],
choose_what_to_sync: false,
keys_optional: false,
can_link_account_uid: false,
pairing: false,
};
vpomerleau
reviewed
Dec 15, 2025
| }); | ||
| signedInUser.authAt = Date.now(); | ||
| signedInUser.email = status.signedInUser?.email || 'unknown'; | ||
| signedInUser.email = status?.signedInUser?.email || 'unknown'; |
Contributor
There was a problem hiding this comment.
Agree with removing the example entirely, but maybe it should be a separate commit/pr merged before this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
closes FXA-12760
Not sure why
this only seems to happen on iOS devices (clicking through a bunch of events) and(looks like there's some desktop events too) this seems to be a relatively small number of events, but it seems fine to just use the optional chaining operator when we reference this.Also, I can just delete
WebChannelExamplein this branch if the reviewer agrees, I don't think we need it as a reference any longer.