Conversation
2cd22e1 to
e0fa392
Compare
…d remote test specs
nshirley
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
*.in.spec.ts) covering: MFA/TOTP, password change, password forgot, recovery codes, recovery email (change, emails, resend code, verify), recovery key, recovery phone, security events, and TOTPmailbox.tshelper intest/support/helpers/for shared email verification utilitiesIssue
Closes: https://mozilla-hub.atlassian.net/browse/FXA-12623
Checklist
Other Information
Continuation of: FXA-12622 (which migrated the first 24 Mocha integration tests to Jest)
mfa_totp.in.spec.tsmfa_totp_tests.jspassword_change.in.spec.tspassword_change_tests.js+password_change_jwt_tests.jspassword_forgot.in.spec.tspassword_forgot_tests.jsrecovery_codes.in.spec.tsrecovery_code_tests.jsrecovery_email_change_email.in.spec.tsrecovery_email_change_email.jsrecovery_email_emails.in.spec.tsrecovery_email_emails.jsrecovery_email_resend_code.in.spec.tsrecovery_email_resend_code_tests.jsrecovery_email_verify.in.spec.tsrecovery_email_verify_tests.jsrecovery_key.in.spec.tsrecovery_key_tests.jsrecovery_phone.in.spec.tsrecovery_phone_tests.jssecurity_events.in.spec.tssecurity_events.jstotp.in.spec.tstotp_tests.jsNotes on deltas
password_change(+6): Jest consolidatespassword_change_jwt_tests.jsinto the same file. Jest also uses explicitfail()guards where Mocha used.then(assert.fail, ...)callback pattern, adding to the count. Added 1 previouslymissing
expect(initialStatus.verified).toBe(true)check.recovery_email_emails(-2): Two remaining.catch(assert.fail)patterns in Mocha are implicit withawaitin Jest (no assertion needed — promise rejection throws automatically). All value-checking assertions now have parity. Added 4 previously missing assertions:client.authAt,requestVerifyEmail()response,sendUnblockCode()response, and second unblock code check.recovery_email_verify(+1): Jest adds an explicitfail()guard not present in Mocha.recovery_key(+1): Jest adds an explicitfail()guard in try/catch replacing Mocha's.then(assert.fail, ...)pattern.recovery_phone(+4): Jest uses explicitfail()guards in try/catch blocks where Mocha relied on implicit promise rejection handling.expect()in Jest.